Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports in snip12 doc code blocks #1182

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

andrew-fleming
Copy link
Collaborator

This PR also proposes to reorder the imports as well by alphabetizing them via scarb fmt. We can change this back if it's preferred to have the openzeppelin import at the top

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (f7b7a7b) to head (7e68a3d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          46       46           
  Lines        1182     1182           
=======================================
  Hits         1082     1082           
  Misses        100      100           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b7a7b...7e68a3d. Read the comment docs.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@ericnordelo ericnordelo merged commit 57e6049 into OpenZeppelin:main Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants