Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements for the token module #1208

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

ericnordelo
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (fcace70) to head (30f01cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          49       49           
  Lines        1394     1394           
=======================================
  Hits         1283     1283           
  Misses        111      111           
Files with missing lines Coverage Δ
packages/token/src/common/erc2981/erc2981.cairo 86.79% <ø> (ø)
packages/token/src/erc1155/erc1155.cairo 98.96% <ø> (ø)
packages/token/src/erc1155/erc1155_receiver.cairo 81.81% <ø> (ø)
packages/token/src/erc20/erc20.cairo 96.55% <100.00%> (ø)
packages/token/src/erc721/erc721.cairo 90.24% <ø> (ø)
...tensions/erc721_enumerable/erc721_enumerable.cairo 95.91% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcace70...30f01cd. Read the comment docs.

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Removes default royalty information.
Sets the default royalty percentage and receiver to zero.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ericnordelo ericnordelo merged commit 4d40f5e into OpenZeppelin:main Nov 13, 2024
8 checks passed
@ericnordelo ericnordelo deleted the feat/improve-token-module branch November 13, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants