Minor governance module improvements plus adding veryfing_contract to Delegation #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 49 49
Lines 1398 1399 +1
=======================================
+ Hits 1287 1288 +1
Misses 111 111
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Comment on lines
+86
to
+91
| pub trait VotingUnitsTrait<TState> { | ||
| /// Returns the number of voting units for a given account. For ERC20, this is typically the | ||
| /// token balance. For ERC721, this is typically the number of tokens owned. | ||
| /// | ||
| /// WARNING: While any formula can be used as a measure of voting units, the internal vote | ||
| /// accounting of the contract may be compromised if voting units are transferred in any |
There was a problem hiding this comment.
This is technically breaking since we're changing its path, no? I'd probably add it to the changelog since it's public. WDYT?
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
immrsd
approved these changes
Nov 15, 2024
Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.