Minor improvements to Account package #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
==========================================
- Coverage 92.12% 92.08% -0.04%
==========================================
Files 49 49
Lines 1397 1390 -7
==========================================
- Hits 1287 1280 -7
Misses 110 110
Continue to review full report in Codecov by Sentry.
|
ericnordelo
approved these changes
Nov 19, 2024
| } else { | ||
| assert(MIN_TRANSACTION_VERSION <= tx_version, Errors::INVALID_TX_VERSION); | ||
| } | ||
| assert(is_tx_version_valid(), Errors::INVALID_TX_VERSION); |
andrew-fleming
approved these changes
Nov 19, 2024
Comment on lines
-79
to
+76
| // Check tx version | ||
| let tx_info = get_tx_info().unbox(); | ||
| let tx_version: u256 = tx_info.version.into(); | ||
| // Check if tx is a query | ||
| if (tx_version >= QUERY_OFFSET) { | ||
| assert( | ||
| QUERY_OFFSET + MIN_TRANSACTION_VERSION <= tx_version, Errors::INVALID_TX_VERSION | ||
| ); | ||
| } else { | ||
| assert(MIN_TRANSACTION_VERSION <= tx_version, Errors::INVALID_TX_VERSION); | ||
| } | ||
| assert(is_tx_version_valid(), Errors::INVALID_TX_VERSION); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist