Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename library constructors to initializers #319

Merged
merged 1 commit into from
May 23, 2022
Merged

Rename library constructors to initializers #319

merged 1 commit into from
May 23, 2022

Conversation

martriay
Copy link
Contributor

@martriay martriay commented May 13, 2022 •
edited
Loading

Fixes #312. initialize or initializer? 🤔

andrew-fleming
andrew-fleming approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'd usually say go for the verb (initialize) for a function name, but this is a special case. I agree with how it is—initializer fits best

@martriay martriay merged commit a4116d2 into main May 23, 2022
@martriay martriay deleted the library-initializer-rename branch May 23, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename library constructors to initialize
2 participants
@martriay @andrew-fleming