Optimize _remove_token_from_all_tokens_enumeration
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-fleming
changed the title
_remove_token_from_all_tokens_enumeration
martriay
approved these changes
Jun 14, 2022
|
|
||
| let (new_supply: Uint256) = SafeUint256.sub_le(supply, Uint256(1, 0)) |
There was a problem hiding this comment.
heh benchmarking might be tricky: how do we know adding the if isn't less performant, but we don't notice due this line making up for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to optimize the ERC721 Enumerable library—specifically, the
_remove_token_from_all_tokens_enumerationmethod. Below is a table comparison based on the current tests and here's a gist with the updated library, tests with print statements to replicate the numbers, and a modified tox.ini to print the results.burnburn