Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AccessControl #373

Merged
merged 22 commits into from
Jun 30, 2022
Merged

Implement AccessControl #373

merged 22 commits into from
Jun 30, 2022

Conversation

martriay
Copy link
Contributor

@martriay martriay commented Jun 29, 2022

This PR supersedes #239 and fixes #249.

@martriay martriay requested a review from andrew-fleming June 29, 2022 21:50
@martriay martriay changed the title Feature/accesscontrol Implement AccessControl Jun 29, 2022
@martriay martriay mentioned this pull request Jun 29, 2022
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martriay looks just about good to go! I left a couple small suggestions and questions

tests/access/test_AccessControl.py Outdated Show resolved Hide resolved
tests/access/test_AccessControl.py Outdated Show resolved Hide resolved
src/openzeppelin/access/accesscontrol.cairo Outdated Show resolved Hide resolved
@martriay martriay merged commit ef10be4 into main Jun 30, 2022
@martriay martriay deleted the feature/accesscontrol branch June 30, 2022 12:32
@martriay martriay restored the feature/accesscontrol branch June 30, 2022 12:32
@martriay martriay deleted the feature/accesscontrol branch June 30, 2022 12:32
@martriay martriay restored the feature/accesscontrol branch June 30, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Access Control
3 participants