Integrate docsite #396
Merged
Integrate docsite #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Jul 14, 2022
Co-authored-by: Francisco <frangio.1@gmail.com>
|
Pending items:
Future work, on other PRs:
|
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
|
I'm not sure about mixing light with dark themes, since the dark one is better for code snippets surrounded by text. we could update only the API section but I guess it's better for a designer to look at it along with the rest of the docsite. It will also be easier to modify once we split the API from the rest of the docs, as with the Solidity docs. This is how it the light theme looks in code blocks surrounded by text (ugly): |
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com>
andrew-fleming
approved these changes
Jul 29, 2022
frangio
approved these changes
Jul 29, 2022
Comment on lines
82
to
90
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/account/Account.cairo[Account] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/tests/mocks/ERC165.cairo[ERC165] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/token/erc20/presets/ERC20Mintable.cairo[ERC20Mintable] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/token/erc20/presets/ERC20Pausable.cairo[ERC20Pausable] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/token/erc20/presets/ERC20Upgradeable.cairo[ERC20Upgradeable] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/token/erc20/presets/ERC20.cairo[ERC20] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/token/erc721/presets/ERC721MintableBurnable.cairo[ERC721MintableBurnable] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/token/erc721/presets/ERC721MintablePausable.cairo[ERC721MintablePausable] | ||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/token/erc721/enumerable/presets/ERC721EnumerableMintableBurnable.cairo[ERC721EnumerableMintableBurnable] |
There was a problem hiding this comment.
I would avoid links to main, they can/will break in the future. Not sure if there is a good alternative that won't become out of date too quickly though...
Co-authored-by: Francisco <frangio.1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #266, related to OpenZeppelin/docs.openzeppelin.com#324.