Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused imports #400

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ca11ab1e
Copy link
Contributor

@ca11ab1e ca11ab1e commented Jul 14, 2022

OZ contracts are directly included in several projects (and it will be more and more true with time), and part of code audits are to check for unused imports/variables. Moreover, I think it's always good to get rid of dead code.
If such imports were kept for a reason, please let me know so that I'll learn something :)

I also sorted OZ-specifc imports.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@ca11ab1e ca11ab1e force-pushed the fix-remove-unused-imports branch from 5601e11 to 576f6af Compare July 14, 2022 16:51
Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

Copy link
Contributor

@martriay martriay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@martriay martriay merged commit a526251 into OpenZeppelin:main Jul 15, 2022
@ca11ab1e ca11ab1e deleted the fix-remove-unused-imports branch July 15, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants