Ownable: split assertion checks in two statements #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achab
force-pushed
the
fix/split-assert-checks
branch
from
8367194 to
1e71146
Compare
andrew-fleming
approved these changes
Aug 10, 2022
|
Thanks for this improvement, it is now clear that we're not properly testing for the non owner case, just the zero address special case. We do have a test on ERC721SafeMintableMock, not on the library tests. Could you add the missing tests? |
achab
force-pushed
the
fix/split-assert-checks
branch
from
8fc99f8 to
ced7018
Compare
achab
force-pushed
the
fix/split-assert-checks
branch
from
ced7018 to
036c5cf
Compare
|
Hi there, thanks for the review! I've just added a small test to check that it reverts if the function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421
This PR splits two checks about address in Ownable contracts in two separate
with_attrstatements. Currently, the error message only corresponds to the second check.PR Checklist