Fix account preset link in extensibility.adoc #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: changed broken link for Account contract preset
martriay
suggested changes
Aug 11, 2022
| @@ -79,7 +79,7 @@ They can be deployed as-is or used as templates for customization. | |||
|
|
|||
| Some presets are: | |||
|
|
|||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/ad399728e6fcd5956a4ed347fb5e8ee731d37ec4/src/openzeppelin/account/Account.cairo[Account] | |||
| * https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/account/presets/Account.cairo[Account] | |||
There was a problem hiding this comment.
we avoid linking to main directly to preven broken links down the road. We prefer permalinks, this is, linking to a specific commit hash.
There was a problem hiding this comment.
thanks! In that case, I've also changed the link below to permalink :)
changed main to permalink
martriay
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: changed broken link for Account contract preset
Fixes #????
PR Checklist