Migrate Initializable to component #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnordelo
reviewed
Oct 9, 2023
src/security/initializable.cairo
Outdated
Comment on lines
1
to
8
| /// SPDX-License-Identifier: MIT | ||
| /// OpenZeppelin Contracts for Cairo v0.7.0 (security/initializable.cairo) | ||
| /// | ||
| /// # Initializable Component | ||
| /// | ||
| /// The Initializable component provides a simple mechanism that executes | ||
| /// logic once and only once. This can be useful for setting a contract's | ||
| /// initial state in scenarios where a constructor cannot be used. |
There was a problem hiding this comment.
Suggested change
| /// SPDX-License-Identifier: MIT | |
| /// OpenZeppelin Contracts for Cairo v0.7.0 (security/initializable.cairo) | |
| /// | |
| /// # Initializable Component | |
| /// | |
| /// The Initializable component provides a simple mechanism that executes | |
| /// logic once and only once. This can be useful for setting a contract's | |
| /// initial state in scenarios where a constructor cannot be used. | |
| //! SPDX-License-Identifier: MIT | |
| //! OpenZeppelin Contracts for Cairo v0.7.0 (security/initializable.cairo) | |
| //! | |
| //! # Initializable Component | |
| //! | |
| //! The Initializable component provides a simple mechanism that executes | |
| //! logic once and only once. This can be useful for setting a contract's | |
| //! initial state in scenarios where a constructor cannot be used. |
src/security/initializable.cairo
Outdated
Comment on lines
20
to
27
| trait InternalTrait<TContractState> { | ||
| fn is_initialized(self: @TContractState) -> bool; | ||
| fn initialize(ref self: TContractState); | ||
| } | ||
|
|
||
| impl InternalImpl< | ||
| TContractState, +HasComponent<TContractState> | ||
| > of InternalTrait<ComponentState<TContractState>> { |
There was a problem hiding this comment.
Suggested change
| trait InternalTrait<TContractState> { | |
| fn is_initialized(self: @TContractState) -> bool; | |
| fn initialize(ref self: TContractState); | |
| } | |
| impl InternalImpl< | |
| TContractState, +HasComponent<TContractState> | |
| > of InternalTrait<ComponentState<TContractState>> { | |
| #[generate_trait] | |
| impl InternalImpl< | |
| TContractState, +HasComponent<TContractState> | |
| > of InternalTrait<TContractState> { |
| @@ -0,0 +1,19 @@ | |||
| #[starknet::contract] | |||
| mod InitializableMock { | |||
| use openzeppelin::security::initializable::Initializable as initializable_comp; | |||
There was a problem hiding this comment.
Suggested change
| use openzeppelin::security::initializable::Initializable as initializable_comp; | |
| use openzeppelin::security::initializable::Initializable as initializable_component; |
Comment on lines
5
to
6
| component!(path: initializable_comp, storage: initializable, event: InitializableEvent); | ||
| impl InternalImpl = initializable_comp::InternalImpl<ContractState>; |
There was a problem hiding this comment.
Suggested change
| component!(path: initializable_comp, storage: initializable, event: InitializableEvent); | |
| impl InternalImpl = initializable_comp::InternalImpl<ContractState>; | |
| component!(path: initializable_comp, storage: initializable, event: InitializableEvent); | |
| impl InternalImpl = initializable_comp::InternalImpl<ContractState>; |
ericnordelo
reviewed
Oct 11, 2023
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #758 and fixes #757.