-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support higher tx versions in Account #858
Support higher tx versions in Account #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good andrew! Left a small suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Benchmarking gas in query tx version checkThe following snippets show the different logic with checking the transaction versions within AccountComponent's This PR now proposes to check if the query version is a supported version, but there is a small increase in gas. The table at the bottom of this comment compares the gas estimates from the test runner. Without query version check:
With query version check:
|
That's very low, and it will get proportionally smaller the bigger is the |
Fixes #830.
PR Checklist