Address versioning and presets issues #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-fleming
approved these changes
Jan 30, 2024
This was
linked to
issues
Jan 30, 2024
ericnordelo
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
LGTM!
On the other hand, shouldn't we create a PR for updating the release-v0.8.1 branch for just updating the wording? I still think we shouldn't wait next release for this. This is regarding #873
|
@ericnordelo created #880 for that |
martriay
added a commit
that referenced
this pull request
Jan 31, 2024
* fix cairo version * update class hashes * fix scarb.toml version number * add presets explainer * update wording
martriay
added a commit
that referenced
this pull request
Jan 31, 2024
* Address versioning and presets issues (#879) * fix cairo version * update class hashes * fix scarb.toml version number * add presets explainer * update wording * fix wording * fix word
martriay
added a commit
that referenced
this pull request
Jan 31, 2024
* bump version and update changelog * fix docs links * update class hashes to cairo 2.4.1 * Address versioning and presets issues (#879) * fix cairo version * update class hashes * fix scarb.toml version number * add presets explainer * update wording * fix wording * fix word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #872, #873, #876. It also fixes: