Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add auto check typos flow when RP #957

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

momodaka
Copy link
Contributor

Add typo check step in github flow, use git action auto check typo issues

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is certainly a nice addition to our workflows.

.github/workflows/typos.yaml Outdated Show resolved Hide resolved
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
@ericnordelo
Copy link
Member

After main is merged into this PR, the check should pass, and we can merge it back.

@momodaka
Copy link
Contributor Author

momodaka commented Apr 2, 2024

After main is merged into this PR, the check should pass, and we can merge it back.

merged and found a new typo issue, fixed yet.

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo ericnordelo merged commit 17e6bcc into OpenZeppelin:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants