Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs with mixin when applicable #966

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Update docs with mixin when applicable #966

merged 3 commits into from
Apr 12, 2024

Conversation

ericnordelo
Copy link
Member

Fixes #948

andrew-fleming
andrew-fleming reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code blocks look so much better! I found a few hidden ones we can also update:

  • overview docsite page
  • security page with Pausable
    • we can use the ownable mixin
  • readme

andrew-fleming
andrew-fleming approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo ericnordelo merged commit bb15d2a into OpenZeppelin:main Apr 12, 2024
6 checks passed
@ericnordelo ericnordelo deleted the docs/use-mixins-#948 branch April 12, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MixinImpls in documentation examples
2 participants
@ericnordelo @andrew-fleming