Add ERC1155 Hooks #982
Merged
Add ERC1155 Hooks #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-fleming
approved these changes
May 9, 2024
Comment on lines
+246
to
+247
| using ERC1155Component is expected to provide an implementation of the ERC1155HooksTrait. For basic token contracts, an | ||
| empty implementation with no logic must be provided. |
There was a problem hiding this comment.
Should we highlight ERC1155Component and/or ERC1155HooksTrait or do you think they're good as is?
There was a problem hiding this comment.
We might add a link to the ERC1155HooksTrait, but since we don't have a doc entry for it, I don't think it is worth it.
I created a page in notion for style guidelines for as to start adding an following the rules in there, and I added rule No. 1 for doc-site being module names shouldn't be coded unless the are code units (e. g. use clauses).
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #965
PR Checklist