Merged
Conversation
0xisk
requested changes
Mar 28, 2025
Member
0xisk
left a comment
0xisk
left a comment
There was a problem hiding this comment.
Thanks @andrew-fleming generally LGTM! Just left some comments & questions.
emnul
approved these changes
Apr 2, 2025
0xisk
reviewed
Apr 4, 2025
test(contracts): more tests on ERC20 unshieleded.
0xisk
approved these changes
Apr 5, 2025
Member
0xisk
left a comment
0xisk
left a comment
There was a problem hiding this comment.
Looks great! thank you @andrew-fleming!
emnul
reviewed
Apr 7, 2025
emnul
pushed a commit
that referenced
this pull request
Jun 26, 2025
* test: adding more tests in ERC20 contract * catch mint overflow to output a more readable error msg * add overflow tests * fix test assertions * add initial module doc * remove contract dir * re-add erc20 * use utils zero address check in erc20 * fix sim export * remove file * remove unused type * add line * set metadata as sealed * add initializer comment * add return comment to initializer --------- Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
emnul
pushed a commit
that referenced
this pull request
Jun 26, 2025
* test: adding more tests in ERC20 contract * catch mint overflow to output a more readable error msg * add overflow tests * fix test assertions * add initial module doc * remove contract dir * re-add erc20 * use utils zero address check in erc20 * fix sim export * remove file * remove unused type * add line * set metadata as sealed * add initializer comment * add return comment to initializer --------- Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
emnul
pushed a commit
that referenced
this pull request
Jun 26, 2025
* test: adding more tests in ERC20 contract * catch mint overflow to output a more readable error msg * add overflow tests * fix test assertions * add initial module doc * remove contract dir * re-add erc20 * use utils zero address check in erc20 * fix sim export * remove file * remove unused type * add line * set metadata as sealed * add initializer comment * add return comment to initializer --------- Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TMP - This PR is still a draft and some features like the approval mechanism need work. This is mostly due to how nested maps need to be initialized. We also need to have a way to change the caller context in tests so we can test that Alice can call
foobut not BobResolves #4.