Skip to content

Comments

Fix fmt issue#143

Merged
andrew-fleming merged 1 commit intomainfrom
fix-fmt-conflict
Jun 23, 2025
Merged

Fix fmt issue#143
andrew-fleming merged 1 commit intomainfrom
fix-fmt-conflict

Conversation

@andrew-fleming
Copy link
Contributor

@andrew-fleming andrew-fleming commented Jun 20, 2025

This PR proposes to eliminate the biome <> yarn formatting conflict by ignoring package.json in biome's formatter config. The package.json is already being formatted by yarn and AFAICT the path of least resistance is to ignore it in biome. We could change how yarn is operating, but there are some tradeoffs and for this type of issue, I don't think it's worth it

Fixes #142

PR Checklist

  • Tests
  • Documentation

@andrew-fleming andrew-fleming requested a review from a team as a code owner June 20, 2025 03:14
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emnul
Copy link
Contributor

emnul commented Jun 23, 2025

I wanted to point out that it looks like biome v2 fixes this issue. I've created a new issue to upgrade to the newest major version #150. Approving this anyway since #150 is out of scope for this PR.

@andrew-fleming
Copy link
Contributor Author

I wanted to point out that it looks like biome v2 fixes this issue. I've created a new issue to upgrade to the newest major version #150. Approving this anyway since #150 is out of scope for this PR.

Good find 👍

@andrew-fleming andrew-fleming merged commit a2365f9 into main Jun 23, 2025
4 checks passed
andrew-fleming added a commit that referenced this pull request Jun 25, 2025
emnul pushed a commit that referenced this pull request Jun 26, 2025
emnul pushed a commit that referenced this pull request Jun 26, 2025
emnul pushed a commit that referenced this pull request Jun 26, 2025
@andrew-fleming andrew-fleming deleted the fix-fmt-conflict branch July 8, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting fmt between yarn and biome

3 participants