Merged
Conversation
0xisk
reviewed
Apr 17, 2025
Member
0xisk
left a comment
0xisk
left a comment
There was a problem hiding this comment.
Thank you @andrew-fleming! LGTM overall just left there is a one comment regarding the Initializable.
0xisk
approved these changes
Apr 24, 2025
Member
0xisk
left a comment
0xisk
left a comment
There was a problem hiding this comment.
LGTM thank you @andrew-fleming!
emnul
pushed a commit
that referenced
this pull request
Jun 5, 2025
* add pausable * update repo structure * move mock contracts to mocks dir * fix initializable tests * move mocks to test * add comments to pausable simulator * add return type to isPaused * add line * fix comment * simplify build script * improve simulator export * fix test file name * Rename pausable.test.ts to Pausable.test.ts * chore: initializable in pausable style (#34) * move initializable and pausable to utils/ * remove barrel files, fix tests * update initializable mock, sim, and tests --------- Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
andrew-fleming
added a commit
that referenced
this pull request
Jun 25, 2025
* add pausable * update repo structure * move mock contracts to mocks dir * fix initializable tests * move mocks to test * add comments to pausable simulator * add return type to isPaused * add line * fix comment * simplify build script * improve simulator export * fix test file name * Rename pausable.test.ts to Pausable.test.ts * chore: initializable in pausable style (#34) * move initializable and pausable to utils/ * remove barrel files, fix tests * update initializable mock, sim, and tests --------- Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
emnul
pushed a commit
that referenced
this pull request
Jun 26, 2025
* add pausable * update repo structure * move mock contracts to mocks dir * fix initializable tests * move mocks to test * add comments to pausable simulator * add return type to isPaused * add line * fix comment * simplify build script * improve simulator export * fix test file name * Rename pausable.test.ts to Pausable.test.ts * chore: initializable in pausable style (#34) * move initializable and pausable to utils/ * remove barrel files, fix tests * update initializable mock, sim, and tests --------- Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
emnul
pushed a commit
that referenced
this pull request
Jun 26, 2025
* add pausable * update repo structure * move mock contracts to mocks dir * fix initializable tests * move mocks to test * add comments to pausable simulator * add return type to isPaused * add line * fix comment * simplify build script * improve simulator export * fix test file name * Rename pausable.test.ts to Pausable.test.ts * chore: initializable in pausable style (#34) * move initializable and pausable to utils/ * remove barrel files, fix tests * update initializable mock, sim, and tests --------- Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
emnul
pushed a commit
that referenced
this pull request
Jun 26, 2025
* add pausable * update repo structure * move mock contracts to mocks dir * fix initializable tests * move mocks to test * add comments to pausable simulator * add return type to isPaused * add line * fix comment * simplify build script * improve simulator export * fix test file name * Rename pausable.test.ts to Pausable.test.ts * chore: initializable in pausable style (#34) * move initializable and pausable to utils/ * remove barrel files, fix tests * update initializable mock, sim, and tests --------- Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
This PR proposes to:
security/directorysecurity/