-
Notifications
You must be signed in to change notification settings - Fork 16
Bump compact 0.25.0 #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compact 0.25.0 #233
Conversation
0xisk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @andrew-fleming, just small comments.
Should not we also update the Compact versions in Dockerfile? https://github.com/OpenZeppelin/compact-contracts/blob/main/.devcontainer/Dockerfile
Co-authored-by: 0xisk <0xisk@proton.me> Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com>
emnul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No breaking syntax changes, tests are green, life is good
0xisk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @andrew-fleming!
Fixes #232. Fixes #195.
This PR proposes to bump the compact compiler version as well as add a changelog