Conversation
cd50394 to
4e2a185
Compare
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* Add issue templates * add PR template * add checklist Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* add security section and doc * fix email * Update README.md Co-authored-by: Iskander <0xisk@proton.me> * fix bare url --------- Co-authored-by: Iskander <0xisk@proton.me> Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* bump midnight-js * remove unused deps * remove eslint and prettier, add biome * run fmt * run lint * organize imports * remove dev deps from contracts/ * remove unused deps * update turbo and scripts * add clean script * add clean script * clean up test config * remove jest reporters * bump turbo to 2.5 * bump turbo * fix package names * set up compact compiler and builder * update scripts * update yarn.lock * update readme * fix fmt * fix fmt * remove lingering file * update biome, fix fmt * add requirements in dev section * add devdeps to contracts packages * simplify workspace * remove unnecessary button rule * fix fmt * remove useExhaustiveDeps rule * Uses recommended compiler options for Node 22 and TypeScript 5.8 * Update compact/src/Builder.ts Co-authored-by: Iskander <0xisk@proton.me> * remove author * Apply suggestions from code review Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com> * Update biome.json Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com> * fix correctness and a11y * remove implicit trailingCommas and indentWidth * add stderr discard notice * change dirent.path to parentPath * add getCompactFiles method * fix lint * Improves type safety via custom error type * output will never be null * remove redundant check * Colocate error types into their own file * Adds type guard to `executeStep` * Add type guard to `compileFile` * Fix fmt * update printOutput function signature --------- Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com> Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* add license * add license * fix copyright year Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* migrate to vitest, bump compact-runtime * use vitest run, remove vitest ui dep * add vitest imports for testing * remove vitest ui * bump compact-runtime to 0.8.1 * set vitest reporters to verbose * fix fmt * fix lint * remove unused dep Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* update nvmrc * bump @types/node Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
4e2a185 to
6c6f486
Compare
Contributor
|
Signed off on previously unverified commits, changing commit history |
emnul
approved these changes
Jun 5, 2025
0xisk
approved these changes
Jun 6, 2025
Member
0xisk
left a comment
There was a problem hiding this comment.
Thank you @andrew-fleming! just left one comment but generally LGTM!
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
0xisk
approved these changes
Jun 6, 2025
emnul
added a commit
that referenced
this pull request
Jun 12, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul
added a commit
that referenced
this pull request
Jun 18, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
andrew-fleming
added a commit
that referenced
this pull request
Jun 25, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul
added a commit
that referenced
this pull request
Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul
added a commit
that referenced
this pull request
Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul
added a commit
that referenced
this pull request
Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul
added a commit
that referenced
this pull request
Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul
added a commit
that referenced
this pull request
Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me> Co-authored-by: Iskander <iskander.andrews@openzeppelin.com> Co-authored-by: Emanuel Solis <esolis6114@gmail.com> Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85.
Waiting on:
PR Checklist