Skip to content

Comments

Add extensibility section#86

Merged
emnul merged 15 commits intomainfrom
add-extensibility-section
Jun 6, 2025
Merged

Add extensibility section#86
emnul merged 15 commits intomainfrom
add-extensibility-section

Conversation

@andrew-fleming
Copy link
Contributor

@andrew-fleming andrew-fleming commented May 26, 2025

Fixes #85.

Waiting on:

PR Checklist

  • Tests
  • Documentation

@emnul emnul force-pushed the add-extensibility-section branch from cd50394 to 4e2a185 Compare June 5, 2025 19:53
andrew-fleming and others added 13 commits June 5, 2025 15:56
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* Add issue templates

* add PR template

* add checklist

Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* add security section and doc

* fix email

* Update README.md

Co-authored-by: Iskander <0xisk@proton.me>

* fix bare url

---------

Co-authored-by: Iskander <0xisk@proton.me>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* bump midnight-js

* remove unused deps

* remove eslint and prettier, add biome

* run fmt

* run lint

* organize imports

* remove dev deps from contracts/

* remove unused deps

* update turbo and scripts

* add clean script

* add clean script

* clean up test config

* remove jest reporters

* bump turbo to 2.5

* bump turbo

* fix package names

* set up compact compiler and builder

* update scripts

* update yarn.lock

* update readme

* fix fmt

* fix fmt

* remove lingering file

* update biome, fix fmt

* add requirements in dev section

* add devdeps to contracts packages

* simplify workspace

* remove unnecessary button rule

* fix fmt

* remove useExhaustiveDeps rule

* Uses recommended compiler options for Node 22 and TypeScript 5.8

* Update compact/src/Builder.ts

Co-authored-by: Iskander <0xisk@proton.me>

* remove author

* Apply suggestions from code review

Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>

* Update biome.json

Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>

* fix correctness and a11y

* remove implicit trailingCommas and indentWidth

* add stderr discard notice

* change dirent.path to parentPath

* add getCompactFiles method

* fix lint

* Improves type safety via custom error type

* output will never be null

* remove redundant check

* Colocate error types into their own file

* Adds type guard to `executeStep`

* Add type guard to `compileFile`

* Fix fmt

* update printOutput function signature

---------

Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* add license

* add license

* fix copyright year

Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* migrate to vitest, bump compact-runtime

* use vitest run, remove vitest ui dep

* add vitest imports for testing

* remove vitest ui

* bump compact-runtime to 0.8.1

* set vitest reporters to verbose

* fix fmt

* fix lint

* remove unused dep

Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
* update nvmrc

* bump @types/node

Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
Signed-off-by: Emanuel Solis <esolis6114@gmail.com>
@emnul emnul force-pushed the add-extensibility-section branch from 4e2a185 to 6c6f486 Compare June 5, 2025 19:56
@emnul
Copy link
Contributor

emnul commented Jun 5, 2025

Signed off on previously unverified commits, changing commit history

@emnul emnul marked this pull request as ready for review June 5, 2025 20:47
@emnul emnul requested a review from a team as a code owner June 5, 2025 20:47
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andrew-fleming! just left one comment but generally LGTM!

Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
@emnul emnul requested a review from 0xisk June 6, 2025 16:21
@emnul emnul merged commit 7fe839b into main Jun 6, 2025
emnul added a commit that referenced this pull request Jun 12, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul added a commit that referenced this pull request Jun 18, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
andrew-fleming added a commit that referenced this pull request Jun 25, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul added a commit that referenced this pull request Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul added a commit that referenced this pull request Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul added a commit that referenced this pull request Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul added a commit that referenced this pull request Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
emnul added a commit that referenced this pull request Jun 26, 2025
Co-authored-by: Iskander <0xisk@proton.me>
Co-authored-by: Iskander <iskander.andrews@openzeppelin.com>
Co-authored-by: Emanuel Solis <esolis6114@gmail.com>
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
@emnul emnul deleted the add-extensibility-section branch July 8, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extensibility doc

3 participants