Skip to content

Change default voting delay for Governor #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2023
Merged

Change default voting delay for Governor #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92aefd3
Change default voting delay
ericglau May 25, 2023
44c46cf
Update changelog
ericglau May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- **Breaking change**: Update to OpenZeppelin Contracts 4.9. ([#252](https://github.com/OpenZeppelin/contracts-wizard/pull/252))
- Change default voting delay to 1 day in `governor`. ([#258](https://github.com/OpenZeppelin/contracts-wizard/pull/258))

## 0.2.3 (2023-03-23)

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/governor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function testGovernor(title: string, opts: Partial<GovernorOptions>) {
test(title, t => {
t.is(governor.print(opts), printContract(buildGovernor({
name: 'MyGovernor',
delay: '1 block',
delay: '1 day',
period: '1 week',
...opts,
})));
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/governor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { durationToBlocks } from "./utils/duration";

export const defaults: Required<GovernorOptions> = {
name: 'MyGovernor',
delay: '1 block',
delay: '1 day',
period: '1 week',

votes: 'erc20votes',
Expand Down