-
Notifications
You must be signed in to change notification settings - Fork 183
Add AccessManaged #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AccessManaged #298
Conversation
Amxx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Just wondering how the constructor argument will show up in the UI. Things like name, symbol, premint are hardcoded, and they don't show up in the constructor argument. What is the logic for what should/shouldn't be a constructor argument ? |
|
The constructor argument would need to be passed through. It does not appear in the UI selection items, only in the resulting contract, e.g. We specifically add this as a constructor argument to the Wizard-generated contract using |
ernestognw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ericglau
No description provided.