Skip to content

Conversation

@ericglau
Copy link
Member

No description provided.

@ericglau ericglau requested a review from a team October 16, 2023 21:46
Copy link
Contributor

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amxx
Copy link
Contributor

Amxx commented Oct 17, 2023

Just wondering how the constructor argument will show up in the UI.

Things like name, symbol, premint are hardcoded, and they don't show up in the constructor argument. What is the logic for what should/shouldn't be a constructor argument ?

@ericglau
Copy link
Member Author

ericglau commented Oct 17, 2023

The constructor argument would need to be passed through. It does not appear in the UI selection items, only in the resulting contract, e.g.

contract MyToken is ERC20, AccessManaged {
    constructor(address initialAuthority)
        ERC20("MyToken", "MTK")
        AccessManaged(initialAuthority)
    {}
}

We specifically add this as a constructor argument to the Wizard-generated contract using addConstructorArgument

@ericglau ericglau marked this pull request as ready for review October 17, 2023 19:55
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ericglau

@github-actions github-actions bot mentioned this pull request Jun 19, 2025
This was referenced Aug 12, 2025
@github-actions github-actions bot mentioned this pull request Aug 28, 2025
This was referenced Sep 16, 2025
This was referenced Oct 29, 2025
This was referenced Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants