Add stablecoin and real world asset tabs #404
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
|
Are the "Stablecoin" and "Real-World Assets" tabs intended to be identical? |
Yes -- pointing to same page. |
Do we expect these to become different at some point, in a way that is not backwards compatible? This question relates to semantic versioning of the external API. If we indicate that these are experimental, then that allows us to change them in the future without bumping the major version. |
Yeah, these two tabs should be marked/labelled as experimental |
| return opts.mintable || opts.limitations !== false || opts.custodian || opts.pausable || opts.upgradeable === 'uups'; | ||
| } | ||
|
|
||
| export function buildStablecoin(opts: StablecoinOptions): Contract { |
There was a problem hiding this comment.
Would it make sense to just "extend" erc20.ts in some way to add limitations and custodian and whatever else is needed, without having to duplicate the code building logic of ERC20? I don't think this needs to be done for this PR though.
| </label> | ||
| </section> | ||
|
|
||
| <section class="controls-section"> |
There was a problem hiding this comment.
After this PR, we should consider whether this can just extend ERC20Controls.svelte in some way, similar to my other comment for the code building.
Co-authored-by: Eric Lau <ericglau@outlook.com>
…' into add-stables
2 participants
No description provided.