Skip to content

Conversation

@GianfrancoBazzani
Copy link
Member

This PR fixes the function printer to respect the modifier order suggested by Solidity Style Guide

Example, before:

image

Example, after:

image

@socket-security
Copy link

socket-security bot commented Feb 20, 2025

@ericglau ericglau changed the title 💅 style: Fix modifiers order to follow Solidity style guides Fix modifiers order to follow Solidity style guides Feb 20, 2025
Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, thanks! Can you also add an entry at the top of packages/core/solidity/CHANGELOG.md in a new Unreleased section?

@GianfrancoBazzani GianfrancoBazzani force-pushed the fix-modifiers-order branch 2 times, most recently from 56ba43a to 9cfee18 Compare February 20, 2025 23:41
Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants