-
Notifications
You must be signed in to change notification settings - Fork 183
Fix modifiers order to follow Solidity style guides #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modifiers order to follow Solidity style guides #450
Conversation
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@nomicfoundation/hardhat-toolbox@5.0.0, npm/svelte-check@3.8.6, npm/svelte-preprocess@5.1.4, npm/svelte@3.59.2, npm/tailwindcss@3.4.17, npm/tippy.js@6.3.7, npm/tslib@2.8.1, npm/util@0.12.5 |
2050d45 to
0799498
Compare
ericglau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, thanks! Can you also add an entry at the top of packages/core/solidity/CHANGELOG.md in a new Unreleased section?
56ba43a to
9cfee18
Compare
016314b to
dba7cd7
Compare
ericglau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR fixes the function printer to respect the modifier order suggested by Solidity Style Guide
Example, before:
Example, after: