-
Notifications
You must be signed in to change notification settings - Fork 183
Support Cairo 2.11.3 #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Cairo 2.11.3 #491
Conversation
ericnordelo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| export const scarbVersion = '2.11.3'; | ||
|
|
||
| /** | ||
| * Semantic version string representing of the minimum compatible version of Contracts to display in output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should compatibleContractsSemver below be updated to ^2.0.0-alpha.0?
Although ^2.0.0-alpha still works because ^2.0.0-alpha has a lower semver than ^2.0.0-alpha.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go with ^2.0.0-alpha.0. Btw, @ericnordelo are we going to release a final alpha version (2.0.0-alpha) or it's unlikely to happen?
If we really want to explicitly exclude the potential final alpha version, we can update the compatible semver to ">=2.0.0-alpha.0 <2.0.0-alpha"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.0.0-alpha is not suitable for a final alpha, because according to semver, 2.0.0-alpha < 2.0.0-alpha.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, @ericnordelo are we going to release a final alpha version
I don't think is worth it. We will just release a stable version from the latest alpha after the audits, so every alpha should have a number
30e05eb
into
OpenZeppelin:aggregate-cairo-alpha-preparations
No description provided.