Skip to content

Conversation

@immrsd
Copy link
Contributor

@immrsd immrsd commented Mar 24, 2025

No description provided.

@immrsd immrsd requested review from ericglau and ericnordelo March 24, 2025 10:33
@immrsd immrsd self-assigned this Mar 24, 2025
@immrsd immrsd marked this pull request as ready for review March 24, 2025 10:33
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

export const scarbVersion = '2.11.3';

/**
* Semantic version string representing of the minimum compatible version of Contracts to display in output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should compatibleContractsSemver below be updated to ^2.0.0-alpha.0?
Although ^2.0.0-alpha still works because ^2.0.0-alpha has a lower semver than ^2.0.0-alpha.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go with ^2.0.0-alpha.0. Btw, @ericnordelo are we going to release a final alpha version (2.0.0-alpha) or it's unlikely to happen?

If we really want to explicitly exclude the potential final alpha version, we can update the compatible semver to ">=2.0.0-alpha.0 <2.0.0-alpha"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.0-alpha is not suitable for a final alpha, because according to semver, 2.0.0-alpha < 2.0.0-alpha.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, @ericnordelo are we going to release a final alpha version

I don't think is worth it. We will just release a stable version from the latest alpha after the audits, so every alpha should have a number

@socket-security
Copy link

socket-security bot commented Mar 25, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@babel/helper-validator-identifier@7.25.9, npm/@eslint-community/eslint-utils@4.4.1, npm/@eslint-community/regexpp@4.12.1, npm/@eslint/config-array@0.19.2, npm/@eslint/core@0.12.0, npm/@eslint/eslintrc@3.3.0, npm/@eslint/js@9.21.0, npm/@eslint/object-schema@2.1.6, npm/@eslint/plugin-kit@0.2.7, npm/@humanfs/core@0.19.1, npm/@humanfs/node@0.16.6, npm/@humanwhocodes/module-importer@1.0.1, npm/@humanwhocodes/retry@0.4.2, npm/@jest/types@24.9.0, npm/@pkgr/core@0.1.1, npm/@types/estree@1.0.6, npm/@types/istanbul-lib-coverage@2.0.6, npm/@types/istanbul-lib-report@3.0.3, npm/@types/istanbul-reports@1.1.2, npm/@types/json-schema@7.0.15, npm/@types/node@18.19.81, npm/@types/normalize-package-data@2.4.4, npm/@types/yargs-parser@21.0.3, npm/@types/yargs@13.0.12, npm/@typescript-eslint/eslint-plugin@8.25.0, npm/@typescript-eslint/parser@8.25.0, npm/@typescript-eslint/scope-manager@8.25.0, npm/@typescript-eslint/type-utils@8.25.0, npm/@typescript-eslint/types@8.25.0, npm/@typescript-eslint/typescript-estree@8.25.0, npm/@typescript-eslint/utils@8.25.0, npm/@typescript-eslint/visitor-keys@8.25.0, npm/acorn-jsx@5.3.2, npm/ajv@6.12.6, npm/ansi-regex@4.1.1, npm/ava@6.2.0, npm/bluebird@3.7.2, npm/browserslist@4.24.4, npm/builtin-modules@4.0.0, npm/callsites@3.1.0, npm/camelcase@5.3.1, npm/caniuse-lite@1.0.30001701, npm/ci-info@4.1.0, npm/clean-regexp@1.0.0, npm/cliui@5.0.0, npm/core-js-compat@3.40.0, npm/cross-spawn@7.0.6, npm/decamelize@1.2.0, npm/electron-to-chromium@1.5.105, npm/emoji-regex@7.0.3, npm/end-of-stream@1.4.4, npm/eslint-config-prettier@10.0.2, npm/eslint-plugin-prettier@5.2.3, npm/eslint-plugin-unicorn@57.0.0, npm/eslint-scope@8.2.0, npm/eslint-visitor-keys@4.2.0, npm/eslint@9.21.0, npm/esquery@1.6.0, npm/esrecurse@4.3.0, npm/execa@1.0.0, npm/fast-diff@1.3.0, npm/fast-json-stable-stringify@2.1.0, npm/file-entry-cache@8.0.0, npm/find-up-simple@1.0.0, npm/flat-cache@4.0.1, npm/flatted@3.3.3, npm/get-stream@4.1.0, npm/glob-parent@6.0.2, npm/globals@14.0.0, npm/graphemer@1.4.0, npm/hosted-git-info@7.0.2, npm/import-fresh@3.3.1, npm/imurmurhash@0.1.4, npm/indent-string@5.0.0, npm/index-to-position@0.1.2, npm/is-builtin-module@4.0.0, npm/is-stream@1.1.0, npm/jest-changed-files@24.9.0, npm/js-tokens@4.0.0, npm/jsesc@3.1.0, npm/json-buffer@3.0.1, npm/json-schema-traverse@0.4.1, npm/json-stable-stringify-without-jsonify@1.0.1, npm/keyv@4.5.4, npm/levn@0.4.1, npm/lodash.merge@4.6.2, npm/lru-cache@10.4.3, npm/min-indent@1.0.1, npm/natural-compare@1.4.0, npm/nice-try@1.0.5, npm/node-releases@2.0.19, npm/normalize-package-data@6.0.2, npm/npm-run-path@2.0.2, npm/optionator@0.9.4, npm/p-finally@1.0.0, npm/p-try@2.2.0, npm/parent-module@1.0.1, npm/parse-json@8.1.0, npm/path-key@3.1.1, npm/pluralize@8.0.0, npm/prelude-ls@1.2.1, npm/prettier-linter-helpers@1.0.0, npm/prettier@3.5.2, npm/pump@3.0.2, npm/punycode@2.3.1, npm/read-package-up@11.0.0, npm/read-pkg@9.0.1, npm/regexp-tree@0.1.27, npm/regjsparser@0.12.0, npm/require-main-filename@2.0.0, npm/resolve-from@4.0.0, npm/rimraf@5.0.10, npm/set-blocking@2.0.0, npm/shebang-command@2.0.0, npm/shebang-regex@3.0.0, npm/signal-exit@3.0.7, npm/spdx-correct@3.2.0, npm/spdx-exceptions@2.5.0, npm/spdx-expression-parse@3.0.1, npm/spdx-license-ids@3.0.21, npm/split@1.0.1, npm/strip-eof@1.0.0, npm/strip-indent@4.0.0, npm/synckit@0.9.2, npm/through@2.3.8, npm/ts-api-utils@2.0.1, npm/tslib@2.8.1, npm/type-fest@4.35.0, npm/typescript-eslint@8.25.0, npm/unicorn-magic@0.1.0, npm/update-browserslist-db@1.1.2, npm/uri-js@4.4.1, npm/validate-npm-package-license@3.0.4, npm/which-module@2.0.1, npm/which@2.0.2, npm/wrap-ansi@5.1.0, npm/wsrun@5.2.4, npm/y18n@4.0.3, npm/yargs-parser@13.1.2, npm/yargs@13.3.2

View full report↗︎

@immrsd immrsd requested a review from ericglau March 25, 2025 06:48
@immrsd immrsd merged commit 30e05eb into OpenZeppelin:aggregate-cairo-alpha-preparations Mar 25, 2025
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants