Add Account compilation tests and simplify community contracts imports #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestognw
changed the title
@openzeppelin/community-contracts imports
ericglau
reviewed
May 1, 2025
| @@ -0,0 +1,2 @@ | |||
| @openzeppelin/community-contracts/=node_modules/@openzeppelin/community-contracts/contracts/ | |||
| @openzeppelin/contracts-upgradeable/=node_modules/@openzeppelin/contracts-upgradeable/ | |||
Member
There was a problem hiding this comment.
Why is remapping necessary for @openzeppelin/contracts-upgradeable?
Member
Author
There was a problem hiding this comment.
tbh not sure but made erc20 compilation tests fail. I think the remappings task might be overriding some default remappings (?)
cost/benefit i thought it was fine to just add the remapping to avoid the rabbit hole 😆
ericglau
approved these changes
May 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds and fixes compilation tests for Accounts, also simplifies the imports of community contracts from
@openzeppelin/community-contracts/contractsto only@openzeppelin/community-contracts. This is the current imports we're recommending on the documentation.