Rename UI Builder label #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughBanner text in packages/ui/public/index.html was updated: the phrase “Contracts UI Builder” was changed to “UI Builder,” and the sentence was split across two lines. No structural, behavioral, or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
< Bug-free code is the new black. >
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/ui/public/index.html (2)
116-119: Use HTTPS for the UI Builder linkAvoid sending users to an insecure HTTP URL.
- <a href="http://builder.openzeppelin.com" target="_blank" rel="noopener noreferrer" class="bg-[#3d3b5d] text-white px-4 py-2 rounded-full text-sm font-medium flex items-center gap-2 hover:bg-[#4a4872] transition-colors no-underline whitespace-nowrap"> + <a href="https://builder.openzeppelin.com" target="_blank" rel="noopener noreferrer" class="bg-[#3d3b5d] text-white px-4 py-2 rounded-full text-sm font-medium flex items-center gap-2 hover:bg-[#4a4872] transition-colors no-underline whitespace-nowrap">
63-63: Preload type mismatch for fontThe href points to a .ttf but type is font/woff2. Fixing avoids console warnings and improves hints to the browser.
- <link rel="preload" href="/fonts/Inter-VariableFont_opsz,wght.ttf" as="font" type="font/woff2" crossorigin> + <link rel="preload" href="/fonts/Inter-VariableFont_opsz,wght.ttf" as="font" type="font/ttf" crossorigin>Or switch to a .woff2 asset if available:
<link rel="preload" href="/fonts/Inter-VariableFont_opsz,wght.woff2" as="font" type="font/woff2" crossorigin>
Comment on lines
106
to
109
| <div class="text-sm text-gray-600 leading-tight text-right"> | ||
| <div>After deploying a contract, use the new</div> | ||
| <div>Contracts UI Builder to spin up a quick UI</div> | ||
| <div>After deploying a contract, use the</div> | ||
| <div>new UI Builder to spin up a quick UI</div> | ||
| </div> |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
🧩 Analysis chain
Keep the sentence a single semantic unit for screen readers
Two sibling divs can be announced as separate paragraphs. Prefer one element (visual breaks via spans) and expose the full sentence via aria-label.
- <div class="text-sm text-gray-600 leading-tight text-right">
- <div>After deploying a contract, use the</div>
- <div>new UI Builder to spin up a quick UI</div>
- </div>
+ <div
+ class="text-sm text-gray-600 leading-tight text-right"
+ aria-label="After deploying a contract, use the new UI Builder to spin up a quick UI"
+ >
+ <span class="block" aria-hidden="true">After deploying a contract, use the</span>
+ <span class="block" aria-hidden="true">new UI Builder to spin up a quick UI</span>
+ </div>To ensure naming consistency, search for leftover “Contracts UI Builder” references:
🏁 Script executed:
#!/bin/bash
# Expect: no results (or only this file after change)
rg -n -C1 -i 'Contracts UI Builder|UI Builder' --type=html --type=ts --type=tsx --type=js --type=mdLength of output: 27
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Search repo for occurrences (avoid --type flags that caused error earlier)
echo "Searching for 'Contracts UI Builder' or 'UI Builder' (case-insensitive)..."
rg -n -C1 -i 'Contracts UI Builder|UI Builder' || true
# 2) Also search for the exact sentence fragment to locate the file if needed
echo
echo "Searching for 'After deploying a contract'..."
rg -n -C1 -i 'After deploying a contract' || true
# 3) Print the relevant area of the known file if it exists
echo
echo "Showing packages/ui/public/index.html (lines 90-120) if present..."
if [ -f packages/ui/public/index.html ]; then
nl -ba packages/ui/public/index.html | sed -n '90,120p'
else
echo "packages/ui/public/index.html not found"
fiLength of output: 1245
Keep the sentence a single semantic unit for screen readers
Two sibling divs are announced separately; use an aria-label on the container and aria-hidden on the visual spans.
- <div class="text-sm text-gray-600 leading-tight text-right">
- <div>After deploying a contract, use the</div>
- <div>new UI Builder to spin up a quick UI</div>
- </div>
+ <div
+ class="text-sm text-gray-600 leading-tight text-right"
+ aria-label="After deploying a contract, use the new UI Builder to spin up a quick UI"
+ >
+ <span class="block" aria-hidden="true">After deploying a contract, use the</span>
+ <span class="block" aria-hidden="true">new UI Builder to spin up a quick UI</span>
+ </div>Search results: found additional "UI Builder" usage at packages/ui/public/index.html:116-117 ("Try the UI Builder") — confirm naming consistency.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <div class="text-sm text-gray-600 leading-tight text-right"> | |
| <div>After deploying a contract, use the new</div> | |
| <div>Contracts UI Builder to spin up a quick UI</div> | |
| <div>After deploying a contract, use the</div> | |
| <div>new UI Builder to spin up a quick UI</div> | |
| </div> | |
| <div | |
| class="text-sm text-gray-600 leading-tight text-right" | |
| aria-label="After deploying a contract, use the new UI Builder to spin up a quick UI" | |
| > | |
| <span class="block" aria-hidden="true">After deploying a contract, use the</span> | |
| <span class="block" aria-hidden="true">new UI Builder to spin up a quick UI</span> | |
| </div> |
🤖 Prompt for AI Agents
In packages/ui/public/index.html around lines 106 to 109, the two sibling divs
create separate announcements for screen readers; wrap the visual text as inline
elements (e.g., spans) inside a single container and add an aria-label on that
container with the full sentence for screen readers, marking the visual spans
aria-hidden="true" so they are ignored by AT. Also verify the "UI Builder"
naming at lines 116-117 matches exactly and update those occurrences for
consistency if needed.
CoveMB
approved these changes
Sep 24, 2025
son-oz
approved these changes
Sep 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.