-
Notifications
You must be signed in to change notification settings - Fork 183
docs: fix grammar #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix grammar #727
Conversation
ralme1da
commented
Nov 11, 2025
- Fix incorrect article usage: "an Fungible" → "a Fungible" in Stellar docs
|
All contributors have signed the CLA ✍️ ✅ |
WalkthroughMinor documentation and grammar corrections in the Stellar package. README.md fixes grammar in example text, and fungible.ts updates function docstrings without altering logic or behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/stellar/README.md (1)
41-41: Grammar corrections look good, but consider conciseness.The article corrections from "an Fungible" to "a Fungible" are correct. However, static analysis suggests removing "of" from "all of the default settings" to read "all the default settings" or simply "all default settings" for better conciseness.
- To generate the source code for a Fungible contract with all of the default settings: + To generate the source code for a Fungible contract with all the default settings:- To generate the source code for a Fungible contract with some custom settings: + To generate the source code for a Fungible contract with some custom settings:(The second change is already correct; the first could be further improved.)
Also applies to: 46-46
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/core/stellar/README.md(1 hunks)packages/core/stellar/src/fungible.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-19T14:28:19.048Z
Learnt from: ericglau
Repo: OpenZeppelin/contracts-wizard PR: 652
File: packages/core/confidential/src/zip-hardhat.test.ts.md:116-121
Timestamp: 2025-09-19T14:28:19.048Z
Learning: In OpenZeppelin Confidential Contracts, the decimals() function is limited to 6, not the typical 18 decimals found in standard ERC20 tokens. This affects overflow calculations when working with premint amounts and SafeCast.toUint64().
Applied to files:
packages/core/stellar/src/fungible.ts
🪛 LanguageTool
packages/core/stellar/README.md
[style] ~41-~41: Consider removing “of” to be more concise
Context: ...ource code for a Fungible contract with all of the default settings: ```js const contract ...
(ALL_OF_THE)
🔇 Additional comments (2)
packages/core/stellar/src/fungible.ts (2)
180-180: Comment is clear and helpful.The updated comment on line 180 accurately describes the operation and improves code documentation.
206-206: JSDoc improvement: explicit @returns documentation.Adding an explicit
@returnsdescription (line 211) is a best practice that improves API documentation completeness. The description accurately reflects the function's return behavior.Also applies to: 211-211
|
I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement |