-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests to ava + add eslint #41
Conversation
7ef2085
to
41a5ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this was copied for "openzeppelin-transpiler". Just added '@typescript-eslint/no-explicit-any': 'off',
because we need explicit any (in StandardMerkleTree
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we can disable it only where it's used. It's only in StandardMerkleTree
and we can do:
type Leaf = any[];
export interface StandardMerkleTreeData<T extends Leaf> extends MerkleTreeData<T> {
...
This way we only disable the rule in a single place. I think we can benefit of it if it works like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments but looks better than I thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we can disable it only where it's used. It's only in StandardMerkleTree
and we can do:
type Leaf = any[];
export interface StandardMerkleTreeData<T extends Leaf> extends MerkleTreeData<T> {
...
This way we only disable the rule in a single place. I think we can benefit of it if it works like this
"prettier": "^3.2.5", | ||
"rimraf": "^5.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is rimraf
needed? I know is widely used but reducing the surface may be a better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It replaces rm -rf ...
. I think its better for portability.
There are also some any in |
Includes: