Skip to content

fix(packages): export biome on root#193

Merged
0xisk merged 3 commits intomainfrom
fix/helper-packages
Sep 23, 2025
Merged

fix(packages): export biome on root#193
0xisk merged 3 commits intomainfrom
fix/helper-packages

Conversation

@0xisk
Copy link
Member

@0xisk 0xisk commented Sep 3, 2025

Description

Overview

This PR is to fix Biome to be exported on the root.

Resolves

Related to #192

@0xisk 0xisk requested a review from a team as a code owner September 3, 2025 10:53
@netlify
Copy link

netlify bot commented Sep 3, 2025

👷 Deploy request for lunarswap pending review.

A Netlify team Owner will need to approve the deploy before you can run your build.

Are you a team Owner? Visit the deploys page to approve it

Need more help? Learn more in the Netlify docs

Name Link
🔨 Latest commit 53574bf

@0xisk 0xisk requested a review from andrew-fleming September 3, 2025 10:53
@0xisk 0xisk self-assigned this Sep 3, 2025
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error when running build which might be worth addressing:

✖ [BUILD] [1/3] Compiling TypeScript
@midnight-dapps/access-contract:build:     Command failed: tsc --project tsconfig.build.json
✖ [BUILD] Unexpected error: Command failed: tsc --project tsconfig.build.json
@midnight-dapps/access-contract:build: 
@midnight-dapps/access-contract:build:  ELIFECYCLE  Command failed with exit code 1.

Can you confirm? And have you considered bumping the compiler version? Or is the idea to get it out and worry about making it current later?

@0xisk
Copy link
Member Author

0xisk commented Sep 22, 2025

Thank you @andrew-fleming! It should be fixed now. Could you pleas check again?

And have you considered bumping the compiler version? Or is the idea to get it out and worry about making it current later?

I actually have been working on this in this branch: https://github.com/OpenZeppelin/midnight-dapps/tree/refactor/upgrade-compact-0.25 But it is currently blocked because of this issue https://github.com/midnightntwrk/compactc/issues/1343, so I am waiting v0.26.0 to try.

Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running into conflicting compiler version issues on my end, but the rest of the build seems okay 👍

@0xisk 0xisk merged commit b37e6ef into main Sep 23, 2025
7 checks passed
@0xisk 0xisk deleted the fix/helper-packages branch September 23, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants