feat(contracts): shielded token contracts #205
Conversation
👷 Deploy request for lunarswap pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
0xisk
changed the title
|
@andrew-fleming I'm sorry for having those two unrelated commits 508343b, 6aeb82a I just needed origially to fix an workflow failing issue and then I took the chance to enhance the existing workflow. LMK if you prefer that to be in a separate PR. |
Nah n/p 👍 |
andrew-fleming
left a comment
andrew-fleming
left a comment
There was a problem hiding this comment.
Looking good, @0xisk! I left some comments
contracts/shielded-token/src/openzeppelin/ShieldedERC20.compact
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
0xisk
force-pushed
the
feat/shielded-token
branch
2 times, most recently
from
5aa96dc to
aaaa857
Compare
0xisk
force-pushed
the
feat/shielded-token
branch
from
aaaa857 to
206d77c
Compare
andrew-fleming
left a comment
andrew-fleming
left a comment
There was a problem hiding this comment.
Changes look good! I left a few final suggestions/comments, but we're just about good to go. btw I believe there are three other occurrences of midnight-dapps lurking about:
- README
- package.json
- /contracts/math/src/Index.compact
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
contracts/shielded-token/src/test/ShieldedFungibleToken.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
2 participants
Description
This PR is for the Shielded token compact contracts.
Related to: #192