Avoid delegatee balance deduction by delegator #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for confidential-tokens ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Amxx
reviewed
Jul 30, 2025
Comment on lines
56
to
62
| function _allowVotes(address account) internal { | ||
| FHE.allow(super.getVotes(account), account); | ||
| } | ||
|
|
||
| function _allowPastVotes(address account, uint256 timepoint) internal { | ||
| FHE.allow(super.getPastVotes(account, timepoint), account); | ||
| } |
Contributor
There was a problem hiding this comment.
In practice/production, how is that suppose to happen ?
Lets say we want to connect a governor to that contract, and the governor needs to lookup someone's encrypted voting power when they cast a vote. How is that happening?
If I deploy a voting token contract today, and its not upgradeable, how will I connect a governor later ?
Contributor
There was a problem hiding this comment.
(note that super. is superfluous)
Contributor
Author
There was a problem hiding this comment.
Following _validate(..) approach from #130, please see latest commits where access can be customized by developer.
Contributor
james-toussaint
deleted the
bugfix/avoid-delegatee-balance-deduction-by-delegator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.