-
Notifications
You must be signed in to change notification settings - Fork 30
fhevm-v9 #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fhevm-v9 #240
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| import {SepoliaConfig} from "@fhevm/solidity/config/ZamaConfig.sol"; | ||
| import {EthereumConfig} from "@fhevm/solidity/config/ZamaConfig.sol"; | ||
| import {VestingWalletCliffConfidential} from "../../finance/VestingWalletCliffConfidential.sol"; | ||
|
|
||
| abstract contract VestingWalletCliffConfidentialMock is VestingWalletCliffConfidential, SepoliaConfig {} | ||
| abstract contract VestingWalletCliffConfidentialMock is VestingWalletCliffConfidential, EthereumConfig {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| import {SepoliaConfig} from "@fhevm/solidity/config/ZamaConfig.sol"; | ||
| import {EthereumConfig} from "@fhevm/solidity/config/ZamaConfig.sol"; | ||
| import {VestingWalletConfidential} from "../../finance/VestingWalletConfidential.sol"; | ||
|
|
||
| abstract contract VestingWalletConfidentialMock is VestingWalletConfidential, SepoliaConfig {} | ||
| abstract contract VestingWalletConfidentialMock is VestingWalletConfidential, EthereumConfig {} |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,11 +1,11 @@ | ||||||||||||||||||||||||
| // SPDX-License-Identifier: MIT | ||||||||||||||||||||||||
| pragma solidity ^0.8.27; | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| import {SepoliaConfig} from "@fhevm/solidity/config/ZamaConfig.sol"; | ||||||||||||||||||||||||
| import {EthereumConfig} from "@fhevm/solidity/config/ZamaConfig.sol"; | ||||||||||||||||||||||||
| import {FHE, ebool, euint64, externalEuint64} from "@fhevm/solidity/lib/FHE.sol"; | ||||||||||||||||||||||||
| import {FHESafeMath} from "./../../utils/FHESafeMath.sol"; | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| contract FHESafeMathMock is SepoliaConfig { | ||||||||||||||||||||||||
| contract FHESafeMathMock is EthereumConfig { | ||||||||||||||||||||||||
|
Comment on lines
+4
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. EthereumConfig still wires zeroed coprocessor/oracle addresses
-import {EthereumConfig} from "@fhevm/solidity/config/ZamaConfig.sol";
+import {SepoliaConfig} from "@fhevm/solidity/config/ZamaConfig.sol";
…
-contract FHESafeMathMock is EthereumConfig {
+contract FHESafeMathMock is SepoliaConfig {📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||
| event HandleCreated(euint64 amount); | ||||||||||||||||||||||||
| event ResultComputed(ebool success, euint64 updated); | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-functional contract: track or implement the missing swap logic.
The entire swap workflow is commented out, leaving the contract with no executable functionality beyond construction. While the PR objectives acknowledge that the logic was unclear, this creates technical debt that should be explicitly tracked.
Concerns:
requestDecryptionat line 28) and new (checkSignaturesat line 35) API patterns, suggesting the migration requirements are not yet fully understoodRecommendations:
Would you like me to help implement the FHEVM v9 migration for these functions based on patterns from other contracts in the PR, or open a tracking issue for this work?
🤖 Prompt for AI Agents