Apply suggestions from code review

Co-authored-by: Ernesto García <ernestognw@gmail.com> Co-authored-by: Francisco <fg@frang.io>
OpenZeppelin · Apr 5, 2023 · 4b61bfe · 4b61bfe
1 parent 11b4ef5
commit 4b61bfe
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/thirty-shrimps-mix.md b/.changeset/thirty-shrimps-mix.md
@@ -2,4 +2,4 @@
 'openzeppelin-solidity': patch
 ---
 
-`TransparentUpgradeableProxy`: fix transparency in case of selector clash with non-decodable calldata
+`TransparentUpgradeableProxy`: Fix transparency in case of selector clash with non-decodable calldata.
diff --git a/contracts/interfaces/IERC1967.sol b/contracts/interfaces/IERC1967.sol
@@ -3,7 +3,7 @@
 pragma solidity ^0.8.0;
 
 /**
- * @dev ERC-1967: Proxy Storage Slots.
+ * @dev ERC-1967: Proxy Storage Slots. This interface contains the events defined in the ERC.
  *
  * _Available since v4.9._
  */
@@ -17,4 +17,9 @@ interface IERC1967 {
  * @dev Emitted when the admin account has changed.
  */
  event AdminChanged(address previousAdmin, address newAdmin);
+
+ /**
+ * @dev Emitted when the beacon is changed.
+ */
+ event BeaconUpgraded(address indexed beacon);
 }
diff --git a/contracts/proxy/transparent/TransparentUpgradeableProxy.sol b/contracts/proxy/transparent/TransparentUpgradeableProxy.sol
@@ -8,7 +8,7 @@ import "../ERC1967/ERC1967Proxy.sol";
 /**
  * @dev Interface for the {TransparentUpgradeableProxy}. This is useful because {TransparentUpgradeableProxy} uses a
  * custom call-routing mechanism, the compiler is unaware of the functions being exposed, and cannot list them. Also
- * {TransparentUpgradeableProxy} does not inherit from this interface because its implemented in a way that the
+ * {TransparentUpgradeableProxy} does not inherit from this interface because it's implemented in a way that the
  * compiler doesn't understand and cannot verify.
  */
 interface ITransparentUpgradeableProxy is IERC1967 {