Optimize Strings equal

OpenZeppelin · May 31, 2023 · 554f2a0 · 554f2a0
1 parent 96b9559
commit 554f2a0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/eighty-crabs-listen.md b/.changeset/eighty-crabs-listen.md
@@ -0,0 +1,5 @@
+---
+'openzeppelin-solidity': patch
+---
+
+Optimize Strings equal
diff --git a/contracts/utils/Strings.sol b/contracts/utils/Strings.sol
@@ -80,6 +80,6 @@ library Strings {
      * @dev Returns true if the two strings are equal.
      */
     function equal(string memory a, string memory b) internal pure returns (bool) {
-        return keccak256(bytes(a)) == keccak256(bytes(b));
+        return bytes(a).length == bytes(b).length && keccak256(bytes(a)) == keccak256(bytes(b));
     }
 }