Use immutable variables where possible (#2528)

Co-authored-by: rotciv <victorfage@gmail.com> Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
OpenZeppelin · Feb 19, 2021 · 7d20d0e · 7d20d0e
1 parent 0059b17
commit 7d20d0e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/contracts/payment/PullPayment.sol b/contracts/payment/PullPayment.sol
@@ -23,7 +23,7 @@ import "./escrow/Escrow.sol";
  * payments with {payments}, and retrieve them with {withdrawPayments}.
  */
 abstract contract PullPayment {
-    Escrow private _escrow;
+    Escrow immutable private _escrow;
 
     constructor () {
         _escrow = new Escrow();

diff --git a/contracts/payment/escrow/RefundEscrow.sol b/contracts/payment/escrow/RefundEscrow.sol
@@ -23,7 +23,7 @@ contract RefundEscrow is ConditionalEscrow {
     event RefundsEnabled();
 
     State private _state;
-    address payable private _beneficiary;
+    address payable immutable private _beneficiary;
 
     /**
      * @dev Constructor.

diff --git a/contracts/token/ERC20/ERC20Capped.sol b/contracts/token/ERC20/ERC20Capped.sol
@@ -8,7 +8,7 @@ import "./ERC20.sol";
  * @dev Extension of {ERC20} that adds a cap to the supply of tokens.
  */
 abstract contract ERC20Capped is ERC20 {
-    uint256 private _cap;
+    uint256 immutable private _cap;
 
     /**
      * @dev Sets the value of the `cap`. This value is immutable, it can only be

diff --git a/contracts/token/ERC20/TokenTimelock.sol b/contracts/token/ERC20/TokenTimelock.sol
@@ -15,13 +15,13 @@ contract TokenTimelock {
     using SafeERC20 for IERC20;
 
     // ERC20 basic token contract being held
-    IERC20 private _token;
+    IERC20 immutable private _token;
 
     // beneficiary of tokens after they are released
-    address private _beneficiary;
+    address immutable private _beneficiary;
 
     // timestamp when token release is enabled
-    uint256 private _releaseTime;
+    uint256 immutable private _releaseTime;
 
     constructor (IERC20 token_, address beneficiary_, uint256 releaseTime_) {
         // solhint-disable-next-line not-rely-on-time