You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both versions of safeTransferFrom have the canTransfer modifier, even though they call transferFrom under the hood (which also includes the canTransfer modifier).
📝 Details
While these extra modifiers may help with readability, they are redundant and highly inefficient. Initial tests show that removing these modifiers saves ~1800 gas for a call of safeTransferFrom with data (likely higher gas savings when calling the version without data, since that adds a third canTransfer check).
The text was updated successfully, but these errors were encountered:
abandeali1
added a commit
to abandeali1/zeppelin-solidity
that referenced
this issue
Jun 19, 2018
🎉 Description
Both versions of
safeTransferFrom
have thecanTransfer
modifier, even though they calltransferFrom
under the hood (which also includes thecanTransfer
modifier).📝 Details
While these extra modifiers may help with readability, they are redundant and highly inefficient. Initial tests show that removing these modifiers saves ~1800 gas for a call of
safeTransferFrom
with data (likely higher gas savings when calling the version without data, since that adds a thirdcanTransfer
check).The text was updated successfully, but these errors were encountered: