ERC20 token with snapshots #1209
Comments
frangio
added
feature
|
Came across this issue in passing. This contract may be helpful. |
|
@frangio I'm trying map in my mind your branch code to current project state. Could you correct me if I'm wrong -> Old StandardToken is just now ERC20 right ? We'r gonna to produce something like SnapshotERC20 or better to stick naming convention ERC20Snapshot ? |
Yes! And we should stick tot he naming convention with something like @jbogacz are you interested in working on this issue? |
|
@frangio Yes, I'm! It's very good candidate to get more familiar with OZ engine. |
|
@jbogacz Awesome. Let me know if you have any questions. |
|
Hey @frangio! It took me a moment but I've created PR. Could you please take a look and let me know about your remarks? Do you suggest to prepare any other test scenario that I missed? I'm looking forward your comments. |
|
Validity Labs is also working on a Snapshot Token. Currently finishing it up now, will do an internal review later this week with the hopes of submitting a PR to OZ. |
* Add Arrays library with unit tests (#1209) * prepared due to snapshot token requirements * add library with method to find upper bound * add unit test for basic and edge cases * Imporove documentation for Arrays library Simplify Arrays.test.js to use short arrays as test date * Added comment for uint256 mid variable. * Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.
…1375) * Add Arrays library with unit tests (OpenZeppelin#1209) * prepared due to snapshot token requirements * add library with method to find upper bound * add unit test for basic and edge cases * Imporove documentation for Arrays library Simplify Arrays.test.js to use short arrays as test date * Added comment for uint256 mid variable. * Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array. (cherry picked from commit f7e53d9)
…pelin-solidity into erc20snapshot-fix#1209
We should have a flavor of ERC20 that adds snapshotting of balances. This mechanism allows for implementing a number of things such as trustless dividends, weighted voting (think DAOs), and forking.
I wrote an implementation that is quite efficient, with O(log(snapshot count)) cost for retrieving past balances, and relatively small constant overhead for transfers. It can be found in my
frangio:feature-snapshot-tokenbranch.I posted this initially in #991 but can't continue working on it for now due to lack of time. Someone needs to complete the work on it by adding comprehensive tests and documentation, and maybe review some naming. After #1097 is merged it should also account for the new internal
_mintand_burnfunctions. We should measure the gas overhead too. Don't hesitate to ask any questions about it!There was some previous discussion in #991, and in #1100 which was a proposal of an implementation that turned out to be too costly.
The text was updated successfully, but these errors were encountered: