Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing address typecast in TokenVesting #1457

Closed
come-maiz opened this issue Oct 20, 2018 · 0 comments · Fixed by #1471
Closed

Missing address typecast in TokenVesting #1457

come-maiz opened this issue Oct 20, 2018 · 0 comments · Fixed by #1471
Labels
contracts Smart contract code. good first issue Low hanging fruit for new contributors to get involved!

Comments

@come-maiz
Copy link
Contributor

On https://github.com/OpenZeppelin/openzeppelin-solidity/blob/dac5bccf803696d9d98d269b8c27c7aac5fa1c5c/contracts/drafts/TokenVesting.sol#L163, We recommend adding an
address​ typecast to ​this​.

This issue was reported in the LevelK audit.
@come-maiz come-maiz added good first issue Low hanging fruit for new contributors to get involved! kind:improvement contracts Smart contract code. labels Oct 20, 2018
alant added a commit to alant/openzeppelin-solidity that referenced this issue Oct 21, 2018
@alant
add an address typecast to this per issue OpenZeppelin#1457
ca15a98
@alant alant mentioned this issue Oct 21, 2018
Merged
nventuro pushed a commit to alant/openzeppelin-solidity that referenced this issue Nov 2, 2018
@alant @nventuro
add an address typecast to this per issue OpenZeppelin#1457
1e43fc0
nventuro pushed a commit that referenced this issue Nov 2, 2018
@alant @nventuro
add an address typecast to this per issue #1457 (#1471)
32bc7a6
vittominacori added a commit to vittominacori/zeppelin-solidity that referenced this issue Nov 21, 2018
@vittominacori
Merge branch 'master' of https://github.com/vittominacori/zeppelin-so…
fd957c4 
…lidity into feature/token-recover

* 'master' of https://github.com/vittominacori/zeppelin-solidity: (98 commits)
  Renamed roles private variables to adhere to code style. (OpenZeppelin#1507)
  Remove extraneous quantity check, fixes OpenZeppelin#1454 (OpenZeppelin#1455)
  Remove redundant require statements (OpenZeppelin#1409)
  Add the step to delete the build dir to the RELEASE notes (OpenZeppelin#1467)
  add an address typecast to this per issue OpenZeppelin#1457 (OpenZeppelin#1471)
  add improvement in simpletoken example OpenZeppelin#1458 (OpenZeppelin#1473)
  SafeMath Test Coverage Improved (OpenZeppelin#1477)
  The beneficiary parameter of claimRefund is replaced with refundee (OpenZeppelin#1481)
  fix ERC20.sol#L174 and ERC20.sol#L187 should be casted to an address type. (OpenZeppelin#1470)
  Fix/add comment erc721 burnable OpenZeppelin#1464 (OpenZeppelin#1469)
  Release v2.0.0
  Release candidate v2.0.0-rc.4
  Improved some ERC721 internal shenanigans (OpenZeppelin#1450)
  Add warning about trading tokens before refundable crowdsale goal is met (OpenZeppelin#1452)
  Crowdsale.buyTokens is now nonReentrant. (OpenZeppelin#1438)
  InitialRate must be strictly larger than finalRate. (OpenZeppelin#1441)
  Fixed how allowance crowdsale checks remaining tokens. (OpenZeppelin#1449)
  Deleted unnecessary import. (OpenZeppelin#1437)
  Made SampleCrowdsale a bit clearer. (OpenZeppelin#1448)
  Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. (OpenZeppelin#1447)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contracts Smart contract code. good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/typecast address this token vesting #1457 alant/openzeppelin-solidity
1 participant
@come-maiz