Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Integer Square Root #4402

Open
chgorman opened this issue Jun 29, 2023 · 2 comments
Open

Improve Integer Square Root #4402

chgorman opened this issue Jun 29, 2023 · 2 comments

Comments

@chgorman
Copy link
Contributor

The integer square root function merged by #3242 is not optimal. A more efficient method would be preferred along with a proof showing the algorithm always produces the correct value.
@chgorman chgorman mentioned this issue Jun 29, 2023
Merged
@ernestognw
Copy link
Member

Hey @chgorman, sorry for the delayed response, we think the proposal you're making requires a bit of study from our side and we're focused on 5.0 at the moment.

We'll definitely come back to check it out after discussing it, probably after 5.0 since this doesn't change the interface and wouldn't be breaking if the function does exactly the same. It'll be a candidate for 5.1.

@chgorman
Copy link
Contributor Author

Feel free to reach out if there are any questions. A previous document discusses validity proofs. Another repo has a more extensive analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chgorman @ernestognw and others