Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named arguments can be used in mapping types in ERC20 #4493

Closed
allwin199 opened this issue Jul 31, 2023 · 4 comments
Closed

Named arguments can be used in mapping types in ERC20 #4493

allwin199 opened this issue Jul 31, 2023 · 4 comments

Comments

@allwin199
Copy link
Contributor

🧐 Motivation

openzeppelin-contracts/contracts/token/ERC20/ERC20.sol

Lines 39 to 41 in d6b63a4

mapping(address => uint256) private _balances;
mapping(address => mapping(address => uint256)) private _allowances;

📝 Details
The Above lines can be changed to this.

mapping(address owner => uint256 value) private _balances; 

mapping(address owner => mapping(address spender => uint256 value)) private _allowances;
@allwin199
Copy link
Contributor Author

I am open to contributing.

@Amxx
Copy link
Collaborator

Amxx commented Jul 31, 2023

This is already addressed by #4433

@Amxx
Copy link
Collaborator

Amxx commented Jul 31, 2023

Duplicate of #4343

@Amxx Amxx marked this as a duplicate of #4343 Jul 31, 2023
@Amxx Amxx closed this as completed Jul 31, 2023
@allwin199
Copy link
Contributor Author

oh sorry! didn't notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amxx @allwin199