-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider changing memory-safe
NatSpec annotations to assembly('memory-safe')
dialect string
#4971
Comments
Regarding the benefits. The only benefit I see is getting ready for solidity 0.9. As stated in the last paragraph of memory-safety conventions docs solidity devs are going to remove the support of NatSpec annotations in the next breaking release. |
Right, so we'll have to make this change before 9.x is released. Not sure when that's going to happen though but I'm adding the 5.x milestone so we tackle it eventually. |
With 0.9, I expect we'll have a lot more than that to change. I would not consider "preparing the codebase for 0.9" something we have to do know. I do prefer the propose notation over natspec. It feels more natural to me to mark the assembly block directly... but that is very personnal. |
This issue came during the audit and we sorted it out on #5172. Closing |
📝 Details
As pointed out by @ZumZoom in #4941 (comment):
Given that we're not supporting any Solidity older than 0.8.20, it makes sense to reconsider changing the NatSpec annotations to the new syntax added in Solidity 0.8.13:
ethereum/solidity#12620
The text was updated successfully, but these errors were encountered: