Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum pragma version to 0.8.19 #4288

Merged

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented May 29, 2023

Bump the minimum pragma version to 0.8.19, since we want to use new language features. At least we want to use named parameters in mapping types, available since 0.8.18. Going with 0.8.19 because we may want to use custom operators for user defined types in the future.

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2023

🦋 Changeset detected

Latest commit: 79109da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ernestognw
Copy link
Member Author

Do we need a changeset for this? I didn't find any other similar entry in the CHANGELOG

@frangio
Copy link
Contributor

frangio commented May 29, 2023

Yes this needs a changeset.

@ernestognw
Copy link
Member Author

Yes this needs a changeset.

Added, thanks!

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestognw
Copy link
Member Author

Gas comparison is failing because bumping the pragma version makes the comparison incompatible but is intended. Tests are passing so I'm manually merging.

@Amxx Amxx merged commit 7bb5592 into OpenZeppelin:next-v5.0 May 29, 2023
This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants