-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum pragma version to 0.8.19
#4288
Bump minimum pragma version to 0.8.19
#4288
Conversation
🦋 Changeset detectedLatest commit: 79109da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Do we need a changeset for this? I didn't find any other similar entry in the CHANGELOG |
Yes this needs a changeset. |
Added, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gas comparison is failing because bumping the pragma version makes the comparison incompatible but is intended. Tests are passing so I'm manually merging. |
Bump the minimum pragma version to 0.8.19, since we want to use new language features. At least we want to use named parameters in mapping types, available since 0.8.18. Going with 0.8.19 because we may want to use custom operators for user defined types in the future.