-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use named arguments in mapping types #4433
Use named arguments in mapping types #4433
Conversation
|
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
just a reminder to link this PR to issue #4343 |
Thanks for the heads up @RenanSouza2, just linked |
contracts/governance/compatibility/GovernorCompatibilityBravo.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Storage layout check failing because of renamed variables or struct members, as expected, but ok for 5.0. |
Fixes #4343
After bumping pragma to 0.8.19 in #4288, we're now able to add named arguments to mapping types. This PR solves that.
PR Checklist
npx changeset add
)