Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solidity-coverage #5231

Closed
Tracked by #5249
ernestognw opened this issue Sep 26, 2024 · 2 comments
Closed
Tracked by #5249

Update solidity-coverage #5231

ernestognw opened this issue Sep 26, 2024 · 2 comments

Comments

@ernestognw
Copy link
Member

Description

On #5218 we're introducing a workaround to coverage issues in the coverage CI for P256. However, this workaround was deprecated in https://github.com/sc-forks/solidity-coverage/releases/tag/v0.8.7

We should update the library and drop the deprecated configuration. However, an attempt of doing so within the PR ended up in the compilation failing with multiple contracts generating unexpected warnings like:

Downloading compiler 0.8.24
Warning: Statement has no effect.
  --> contracts/utils/Context.sol:23:68:
   |
23 |     function _msgSender() internal view virtual returns (address) {abi.encode(0x730c7f785d17a153);  /* function */ 
   |                          
@arr00 arr00 mentioned this issue Oct 25, 2024
3 tasks
@arr00
Copy link
Contributor

arr00 commented Oct 25, 2024

This is a result of using hardhat-ignore-warnings with the default that warnings are errors. The injected code for coverage results in the Statement has no effect warning and it can be safely ignored in coverage runs.

@arr00
Copy link
Contributor

arr00 commented Oct 30, 2024

Per the conversation in #5282, the current config is ideal for our coverage--there are new issues that surface with the method for IR coverage in newer versions of solidity-coverage.

@arr00 arr00 closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants