Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix P256 corner cases #5218

Merged
merged 40 commits into from
Sep 30, 2024
Merged

Fix P256 corner cases #5218

merged 40 commits into from
Sep 30, 2024

Conversation

cairoeth
Copy link
Contributor

Fixes CR-01 and L-05.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@cairoeth cairoeth added this to the 5.1-after-freeze milestone Sep 20, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 427d074

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cairoeth cairoeth mentioned this pull request Sep 23, 2024
Closed
3 tasks
cairoeth and others added 2 commits September 23, 2024 18:01
@cairoeth @Amxx
Update comments
32c1bad 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@cairoeth
Add comment to _jMultShamir
79fb345
@cairoeth cairoeth requested a review from Amxx September 23, 2024 16:11
ernestognw
ernestognw previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out the configureYulOptimizer and solcOptimizerDetails options are deprecated in solcover 0.8.5. I tried updating to the latest version and use viaIR in coverage. However, it raises some issues that require further investigation and we may need access to intermediate configuration.

LGTM, we can discuss upgrading solidity-coverage later

@ernestognw ernestognw mentioned this pull request Sep 26, 2024
Closed
@Amxx @ernestognw
Update contracts/utils/cryptography/P256.sol
4b5943e 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
ernestognw
ernestognw previously approved these changes Sep 27, 2024
View reviewed changes
cairoeth
cairoeth commented Sep 29, 2024
View reviewed changes
contracts/utils/cryptography/P256.sol Outdated Show resolved Hide resolved
contracts/utils/cryptography/P256.sol Outdated Show resolved Hide resolved
@Amxx Amxx changed the title Improve P256._jAdd to support adding identical points. Fix P256 corner cases Sep 30, 2024
@ernestognw ernestognw merged commit e3cfe1c into OpenZeppelin:master Sep 30, 2024
21 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 1, 2024
@cairoeth @Amxx @ernestognw
Fix P256 corner cases (OpenZeppelin#5218)
6709a08 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx added a commit that referenced this pull request Oct 2, 2024
@cairoeth @Amxx @ernestognw
Fix P256 corner cases (#5218)
4e2ac51 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@cairoeth @Amxx @ernestognw