Improved SafeERC20 allowance handling #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a688977.
nventuro
reviewed
Oct 11, 2018
There was a problem hiding this comment.
Awesome @Aniket-Engg, thanks! I'll think a bit about where to put the new allowance function declarations, so all we should do is improve the tests a bit to make usage clearer.
|
I think, build needs to re-run. |
nventuro
reviewed
Oct 16, 2018
|
@Aniket-Engg thank you for your great help, as always! We need to get this fix in soon since we plan on finishing the release tomorrow, so I pushed directly to your branch - sorry about that! |
|
No problem at all @nventuro |
come-maiz
approved these changes
Oct 18, 2018
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * allowance methods in library * Improved SafeERC20 tests. * Fixed test coverage. (cherry picked from commit 315f426)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1404