Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20._approve #1609

Merged
merged 5 commits into from
Jan 21, 2019
Merged

ERC20._approve #1609

merged 5 commits into from
Jan 21, 2019

Conversation

nventuro
Copy link
Contributor

Fixes #1604.

I also refactored the ERC20 tests to that both approve and _approve will be tested directly, to prevent regression errors.

@nventuro nventuro added feature New contracts, functions, or helpers. contracts Smart contract code. labels Jan 16, 2019
@nventuro nventuro added this to the v2.2 milestone Jan 16, 2019
@nventuro nventuro self-assigned this Jan 16, 2019
@nventuro nventuro requested a review from frangio January 16, 2019 15:14
@nventuro nventuro mentioned this pull request Jan 16, 2019
Closed
@nventuro nventuro requested a review from frangio January 21, 2019 19:09
frangio
frangio approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nventuro!

@nventuro nventuro merged commit 3a5da75 into OpenZeppelin:master Jan 21, 2019
@nventuro nventuro deleted the internal-approve branch January 21, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees

@nventuro nventuro

Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio